Fix cmake warnings#651
Open
hgreenlee wants to merge 11 commits into
Open
Conversation
PetrilloAtWork
left a comment
PetrilloAtWork
left a comment
Member
There was a problem hiding this comment.
A couple of file name strings left to change, and a question about one change.
Plus, I was told off-line that there is one more change pending.
Remove unnecessary include dependency in PDMapAlg.h.
7 tasks
Contributor
Author
|
Added interface library for tool PDMapAlg. Made companion PR SBNSoftware/sbndcode#938 |
PetrilloAtWork
approved these changes
Jul 2, 2026
PetrilloAtWork
left a comment
PetrilloAtWork
left a comment
Member
There was a problem hiding this comment.
All looks good to me (not tested though).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix cmake warnings. Mainly one definition rule violations, but some others also.
Companion PR:
SBNSoftware/sbndcode#938